benchmark: add v8 deserialize benchmark#45475
Closed
anonrig wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
nodejs-github-bot
added
the
benchmark
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
CC @nodejs/performance |
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Nov 18, 2022
Ethan-Arrowood
approved these changes
Nov 30, 2022
Contributor
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
would it be valuable to test the serialization/deserialization of other types? Like this does an object with a number and a BigInt prop. Maybe we can add to it other types like string, boolean, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from one of my old pull requests: https://github.com/nodejs/node/pull/43937/files#diff-522a7e332d08116adcf9089cadcf3e161099f99cf877d76a701ce55fe4f4d398